Hi guys 👋 i was wondering, what is supposed to happen if some CheckoutPreConditionPlugin create

U032KG3CGNB

Hi guys 👋 i was wondering, what is supposed to happen if some CheckoutPreConditionPlugin created an Error without an ErrorCode? E.g. https://github.com/spryker/gift-card/blob/94c737ef332b228613346dc1deaff36f54ab5d7b[…]/Spryker/Zed/GiftCard/Business/Payment/SalesOrderPreChecker.php adds an Error without an ErrorCode to the CheckoutResponse if the GiftCard is already used. So the PlaceOrderStep will not have a postConditionErrorRoute and the StepCollections Error Route checkout-error will be used. But because of the PlaceOrderSteps PostCondition $quoteTransfer->getOrderReference() !== null the ErrorSteps PostCondition $quoteTransfer->getOrderReference() === null can never be triggered. The Result is an infinite redirect from place-order-step to error-step and so on. Am i missing something here?

fsmeier

Yes, this is sadly a bug 😞 If you have access through a partner or customer portal you can report it to get better attention

U032KG3CGNB

All right i'll report it then, thank you very much 👌

fsmeier

Workaround which worked for me to not have the loop:

<?php

namespace Pyz\Yves\CheckoutPage\Process;

use Spryker\Yves\StepEngine\Process\StepCollection;
use SprykerShop\Yves\CheckoutPage\Plugin\Router\CheckoutPageRouteProviderPlugin;
use SprykerShop\Yves\CheckoutPage\Process\StepFactory as SprykerStepFactory;

class StepFactory extends SprykerStepFactory
{
    /**
     * @return \Spryker\Yves\StepEngine\Process\StepCollectionInterface
     */
    public function createStepCollection()
    {
        return new StepCollection(
            $this->getRouter(),
            CheckoutPageRouteProviderPlugin::ROUTE_NAME_CHECKOUT_SUMMARY
        );
    }
}

fsmeier

Routing not to error-route but using the summary as default error-route

Alberto Reyer

@U01F7P3D9NH Seems like a solution for the same issue we have as well, what do you think?