Hello again! Simple question (hopefully) just for understanding: For the dependency providers … woul

UPWG9AYH2

Hello again! Simple question (hopefully) just for understanding: For the dependency providers … would there be a downside passing the Container $container variable to each adding-function as „by reference”? I think i already heard a good reason against, but i really can’t remember … Thanks a lot 🙂

Unknown

🤔

Unknown

it’s a class, so passed by reference by default

Unknown

you mean just changing instead of returning and overriding in the calling method, right?

Unknown

what is it you want to achieve?

UPWG9AYH2

if mean instead of
…
$container = $this->addStore($container);
…
do
$this->addStore($container);
….

UPWG9AYH2

and in the function omit the return value

UPWG9AYH2

protected function addStore(Container $container)
{
$container[static::STORE] = function (Container $container) {
return Store::getInstance();
};
}

instead of

protected function addStore(Container $container)
{
    $container[static::STORE] = function (Container $container) {
        return Store::getInstance();
    };

    *return $container;*
}

Unknown

yes, i understand

Unknown

except for the motivation 🙂

UPWG9AYH2

I got the question from a colleague regarding this and i want to give him a plausbile answer 🙂 … so he asked why not using the “short” way instead of doing unnecessary assertions all the time …

UKU1E0ENB

Hi Ingo, both ways work but we decided to always use explicit input and output parameters for methods. In case a parameter is modified inside of a method but not returned then the signature of the method would be misleading. That’s called an inout parameter and I would call it a bad practice.