What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

Hello all, if we use the same sku for both abstract and concrete would it be an issue for spryker?

UM9F81RCP
UM9F81RCP Posts: 516 πŸ§‘πŸ»β€πŸš€ - Cadet

Hello all,

if we use the same sku for both abstract and concrete would it be an issue for spryker?

Comments

  • ULL0N440J
    ULL0N440J Posts: 184 πŸ§‘πŸ»β€πŸš€ - Cadet

    We have added an underscore as prefix to the SKU (for abstract). Even if this isn't an issue: do it for readability πŸ˜…

  • UM9F81RCP
    UM9F81RCP Posts: 516 πŸ§‘πŸ»β€πŸš€ - Cadet

    i was thinking the same πŸ˜„

  • UKTSRTD5M
    UKTSRTD5M Posts: 77 πŸ§‘πŸ»β€πŸš€ - Cadet

    we did use the same sku, and started to get troubles when we introduced some products where this diverges, as it's not always obvious which one is used...

  • UKTSRTD5M
    UKTSRTD5M Posts: 77 πŸ§‘πŸ»β€πŸš€ - Cadet

    So you end with code which only runs by accident - or as long as this stays true

  • UKTSRTD5M
    UKTSRTD5M Posts: 77 πŸ§‘πŸ»β€πŸš€ - Cadet
    edited September 2019

    \Spryker\Zed\Product\Business\ProductFacadeInterface::findProductAbstractIdBySku is on example we struggled with. From the specification / naming what sku do you expect to be used here?

  • giovanni.piemontese
    giovanni.piemontese Technical Lead @ LΓΆffelhardt Spryker Solution Partner Posts: 871 πŸ§‘πŸ»β€πŸš€ - Cadet

    We use the same and we have no problems til now... (but we have only 1 concrete per 1 abstract now...)

  • UKHQ50XFX
    UKHQ50XFX Posts: 31 πŸ§‘πŸ»β€πŸš€ - Cadet

    It's not a problem to use the same SKU for concrete and abstract. you would need to have different a SKU for any concrete beyond the first, but that's a requirement in general since SKUs have to be unique ...

  • s.kroll
    s.kroll Head of Technology Spryker @ basecom Posts: 120 πŸͺ - Explorer

    Just found this topic and want to add some information:
    It looks like at least the DataImport (especially the product-image-import) does not work correct if abstract-sku = concrete-sku