Hi all, we are experiencing some issues with shop-ui release (v1.54.0).

U019JM2HE7N

Hi all, we are experiencing some issues with shop-ui release (v1.54.0).
https://github.com/spryker-shop/shop-ui/compare/1.53.1...1.54.0
We are unable to modify the “isVisible” property of the defined data object in an inherit template. “data.isVisible” keeps always true. Any ideas?
{% extends template('widget') %}
 
{% define data = {
   isVisible: false,
} %}
 
{% block template %}
{{ dump(data.isVisible) }} {# shows true, should be false #}
{% endblock body %}

giovanni.piemontese

@UN6T8SEM7 maybe or @U019DLP9S1F
thanks for your support in advance.

Aleksander Kovalenko

Hi Marcel!
Can it be an issue with {% endblock body %}? Should be {% endblock %} .

giovanni.piemontese

it was a wrong copy & paste.. i noted me too..

Aleksander Kovalenko

So you are using it in widget, correct? Or it’s a general issue for widgets/templates/components?

giovanni.piemontese

In widget.. I send u the example of your project.. (Marcel is just my colleague)

giovanni.piemontese

{% extends template('widget') %}

{% define data = {
    isVisible: _widget.isVisible,
    punchoutDocumentTransferRequestForm: _widget.punchoutDocumentTransferRequestForm,
    textButton: 'punchout.transfer.ids-button' | trans,
} %}

{% block body %}
    {% if data.punchoutDocumentTransferRequestForm is not null %}
        {% include molecule('form') with {
            class: 'col spacing-x spacing-x--inner spacing-x--small spacing-y--big',
            modifiers: ['custom'],
            data: {
                form: data.punchoutDocumentTransferRequestForm,
                options: {
                    action: path('punchout/ids/document/transfer'),
                    attr: {
                        novalidate: 'novalidate',
                    },
                },
                submit: {
                    enable: true,
                    icon: 'swap_horiz',
                    text: data.textButton,
                    class: 'spacing-bottom button button--expand button--hollow button--icon',
                }
            }
        } only %}
    {% endif %}
{% endblock %}

_widget.isVisible is correctly set to false, but body is displayed because data.isVisible is true, even if we overwrite it in define data...

giovanni.piemontese

I suppose only in widget.. we discovered only there at the moment the problem and for this widget template that i posted

giovanni.piemontese

as u see i just made another check
{% if data.punchoutDocumentTransferRequestForm is not null %} to show or not the body.. because isVisible is always true..

Aleksander Kovalenko

Really strange. It’s working for me from first point of view.

giovanni.piemontese

did u tried an example in your project locally?

U019JM2HE7N

Hey @UN6T8SEM7, this seems to be not an issue in connection with the noted shop-ui release.

Is it possible that the "define" Twig Tag is only manipulatable via include or embedding and not via inheritance?

https://documentation.spryker.com/docs/tutorial-how-define-twig-tag-is-working

https://github.com/spryker-shop/shop-ui/blob/master/src/SprykerShop/Yves/ShopUi/Twig/TokenParser/ShopUiDefineTwigTokenParser.php

Aleksander Kovalenko

Nope, the object which is created with define can be changed in extended template.

U019JM2HE7N

You are right, i've checked. We can also overwrite variables in extended templates. The only exception seems to be variables defined in this file vendor/spryker-shop/shop-ui/src/SprykerShop/Yves/ShopUi/Theme/default/models/template.twig
https://github.com/spryker-shop/shop-ui/blob/68c1f61e8bf012310b2c50bb05b2ff1ceb8666a2/src/SprykerShop/Yves/ShopUi/Theme/default/models/template.twig

U019JM2HE7N

Were you able to explicitly overwrite the isVisible Variable?

Aleksander Kovalenko

In several places:
• https://github.com/spryker-shop/company-widget/blob/master/src/SprykerShop/Yves/Co[…]lt/views/menu-item-company-widget/menu-item-company-widget.twig
• https://github.com/spryker-shop/quote-request-widget/blob/master/src/SprykerShop/Y[…]me/default/views/quote-request-create/quote-request-create.twig
And several more

U019JM2HE7N

Thanks for your examples!
These widgets are both inside a component (based on component.twig).
If you place your Widgets directly in a view (based on template.twig), for example page-layout-main.twig it is not possible to overwrite isVisible. Whatever you will define in your widget constructor or template, it will be always true,

Aleksander Kovalenko

Hmmm… sounds really strange. Thanks for this info. I’ll create a bug for it, so we can check what is wrong.