What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

I modified the data importer to read products from s3 and now need to do the same thing for product

U03T08LE3CP
U03T08LE3CP Posts: 185 πŸ§‘πŸ»β€πŸš€ - Cadet
in Help

I modified the data importer to read products from s3 and now need to do the same thing for product labels, am I understanding this correctly that this does not use the same data import mechanism and I need to rewrite a lot of the product label import code?

Comments

  • fsmeier
    fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,106 βš–οΈ - Guardians (admin)

    Hey, yes. Product Labels seem to be handled separately via ProductLabelDataImportPlugin and ProductLabelStoreDataImportPlugin

  • U03T08LE3CP
    U03T08LE3CP Posts: 185 πŸ§‘πŸ»β€πŸš€ - Cadet
    edited December 2022

    I get very lost in ProductLabelDataImportConfig::getProductLabelDataImporterConfiguration why is it adding hard coded csv paths in yaml configuration?

  • fsmeier
    fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,106 βš–οΈ - Guardians (admin)

    Yeah, to be honest: does not make so much sense for me either. It is not flexible. πŸ˜•

  • U03T08LE3CP
    U03T08LE3CP Posts: 185 πŸ§‘πŸ»β€πŸš€ - Cadet

    I can't help to conclude that this is just dead legacy code. I just replaced the ProductLabelDataImportBusinessFactory to use the standard getCsvDataImporterFromConfig and it seems to work, fingers crossed πŸ˜„ :crossed_fingers:

Categories