After updating to 202009 we have a problem with MerchantStorage. All fields of a merchant's address

jochen.gartner

After updating to 202009 we have a problem with MerchantStorage. All fields of a merchant's address are null.

jochen.gartner

It looks like the fromArray->toArray mapping in MerchantStorage/Business/Writer/MerchantStorageWriter.php is wrong due to the different AddressCollection structure in the transfer objects:

https://github.com/spryker/merchant-storage/blob/master/src/Spryker/Shared/MerchantStorage/Transfer/merchant_storage.transfer.xml#L34
vs
https://github.com/spryker/merchant-profile/blob/master/src/Spryker/Shared/MerchantProfile/Transfer/merchant_profile.transfer.xml#L35

Is this a bug or am I missing something?

Valerii Trots

@ULL9CA6CB seems like you could help here probably.

Ahmed Sabaa

As far as I know, Merchant should not have an AddressCollection, you will find your AddressCollection in MerchantTransfer.MerchantProfile or MerchantStorageTransfer.MerchantProfile ..that attribute existing is because of BC (cannot remove attributes from transfers), but it should be deprecated

jochen.gartner

I saw that already, I'm talking about the differences between MerchantProfile.AddressCollection and MerchantStorageProfile.AddressCollection

Ahmed Sabaa

Will check.

jochen.gartner

any news on this @ULL9CA6CB?

Ahmed Sabaa

This is internally being checked at the moment, will get back to you as soon as possible!

jochen.gartner

ok thanks

jochen.gartner

we applied a fix on project level. would be nice if you could ping me if you change this behaviour in core.

Ahmed Sabaa

There is an internal ticket for this that I will update you on when it goes into progress 🙂

Ahmed Sabaa

Thank you a lot Jochen for your input, it was a great catch!