Hello! There is an issue in

UNBSW8S8K

Hello!

There is an issue in https://github.com/spryker/products-categories-resource-relationship/compare/1.0.0...1.1.0 change

The thing is you don’t need to be genius to see that there is really something wrong + it proves that there are no tests on Spryker.

Please see: https://github.com/spryker/products-categories-resource-relationship/blob/1c2007daae3cba94d07d0a6ba37fef1e9e31a090/src/Spryker/Glue/ProductsCategoriesResourceRelationship/Processor/Expander/CategoriesResourceRelationshipExpander.php#L49-L51

and https://github.com/spryker/products-categories-resource-relationship/blob/1c2007daae3cba94d07d0a6ba37fef1e9e31a090/src/Spryker/Glue/ProductsCategoriesResourceRelationship/Processor/Expander/CategoriesResourceRelationshipExpander.php#L65-L68

to find the problem.

Did anyone face this issue as well?

UNBSW8S8K

CC: @UK9N7MP96

Ehsan Zanjani

Hi @UNBSW8S8K
Thanks for the points, I wrote this to our team, we will provide the fix and release it hopefully today.

Ehsan Zanjani

Spryker already provided Unit and Functional tests for all Zed layers, and acceptance tests for Yves.
Glue modules usually don’t need to have tests as they mostly proxy calls to our Client and Zed which already covered by Functional tests, but if there is logic in Glue, we must have test for it.

UNBSW8S8K

@UK9N7MP96 any update about release?

Ehsan Zanjani

Hi Janis, the Fix is done and it’s in our release queue, I’ll push this today, one test has been failed and travis was red

Valerii Trots

https://github.com/spryker/products-categories-resource-relationship/releases/tag/1.1.1

UNBSW8S8K

Thank you @valerii.trots 🎉

Valerii Trots

Always welcome! 👍