What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

👋

U011K6DASBW
U011K6DASBW Posts: 37 🧑🏻‍🚀 - Cadet
in Help

👋 https://github.com/spryker-shop/b2c-demo-shop/blob/master/src/Pyz/Yves/Twig/TwigDependencyProvider.php#L97 shouldn’t this be loaded only when development mode is enabled?

Comments

  • UK7KBE2JW
    UK7KBE2JW Posts: 463 🧑🏻‍🚀 - Cadet

    You have to enable it in config via

    $config[WebProfilerWidgetConstants::IS_WEB_PROFILER_ENABLED] = true;

    so it is no problem

  • U011K6DASBW
    U011K6DASBW Posts: 37 🧑🏻‍🚀 - Cadet

    yes, but the WebProfilerTwigLoaderPlugin class itself does not get loaded by composer when we pass --no-dev option

  • UM53ZHLTF
    UM53ZHLTF Posts: 43 🧑🏻‍🚀 - Cadet

    same for Zed Pyz\Zed\Twig\TwigDependencyProvider and yes we also had to override it to just load for Dev environment

  • U011K6DASBW
    U011K6DASBW Posts: 37 🧑🏻‍🚀 - Cadet

    yes, there are four classes in total, 2 in yves and 2 in zed

  • Serhii Chepela
    Serhii Chepela Sprykee Posts: 49 🧑🏻‍🚀 - Cadet

    As an option you can add a check into depenency providers and add those plugins only if they are exist

  • U011K6DASBW
    U011K6DASBW Posts: 37 🧑🏻‍🚀 - Cadet

    that is what we have done, but it doesn’t feel good to overwrite entire method of dependency provider for this 🙂

  • Serhii Chepela
    Serhii Chepela Sprykee Posts: 49 🧑🏻‍🚀 - Cadet
    edited May 2020

    I wouldn’t call this overwriting since this depenency provider is on the project level in the first place.
    In any case idea of this file from Pyz namespace, that you can modify it in any way you want and add or remove plugins that you want.

  • U011K6DASBW
    U011K6DASBW Posts: 37 🧑🏻‍🚀 - Cadet

    true,, but in our case we have separate namespace for project,, not using Pyz directly

  • Serhii Chepela
    Serhii Chepela Sprykee Posts: 49 🧑🏻‍🚀 - Cadet

    Yep, in this case re-writing method just for that seems not convinient.
    I guess this is not a bad idea to add this check OOTB

Categories