can you return `void` from a GatewayController ? or rather, do we have to create a transfer object e

UKGT7RC7P

can you return void from a GatewayController ? or rather, do we have to create a transfer object even if the action is a notification?

UQS4LDZU7

Had this issue as well. To make it short - you ALWAYS need a transfer. If you dont have any properties to pass, just pass an empty object. That should do the job.

Ievgen Varava

that depends on ZedRequestClient

Ievgen Varava

by default it returns Transfer object from last response

UKGT7RC7P

an empty transfer you mean?

UQS4LDZU7

@UKGT7RC7P Yes.

Ievgen Varava

\Spryker\Shared\ZedRequest\Client\AbstractHttpClient::getTransferFromResponse()

Ievgen Varava

$data = json_decode(trim($response->getBody()), true);
        if (!$data || !is_array($data)) {
            throw new InvalidZedResponseException('Invalid JSON', $response, $request->getUri());
        }

UKGT7RC7P

hm, so you could override the ZedRequestClient

Ievgen Varava

you have to if you really need to return void from gateway controller

UQS4LDZU7

@UKGT7RC7P Never came to this idea, but Ievgen knows for sure better.

UKGT7RC7P

well, often i'd like to pass / return non-transfer objects

UKGT7RC7P

(especially passing)

UKGT7RC7P

seems I often do BlahRequestTransfer and BlahResponseTransfer

UQS4LDZU7

@UKGT7RC7P Passing non-transfer objects (i.e. arrays etc) between app layers breaks the Spryker conventions afaik.

UKGT7RC7P

of course 🙂

UKGT7RC7P

the problem is you end up creating a transfer object per request if they have different args

UKGT7RC7P

or, worse, you use the same transfer object for all of them and have no API at all

UKGT7RC7P

would be so much nicer to just pass arguments

UQS4LDZU7

I agree, it somehow hurts. But, on the other hand, you are welcome to create unlimited amount of TOs 🙂

UKGT7RC7P

👀

UKHD8KTMF

Creating a transfer is a very small overhead, it would be possible to remove this requirement but it takes a lot of overriding on the project level. In my opinion it is just not worth it.

UKHD8KTMF

And by convention you should be sending and receiving a business object ... just saying

UKGT7RC7P

I know that's the convention, but the "business" objects are transfer objects where everything is nullable

UKHD8KTMF

you can always return true if action is successful

UKGT7RC7P

can you? 🤔

UKHD8KTMF

wrapped in a transfer of course

UKGT7RC7P

BooleanTransfer.php

UKHD8KTMF

I usually make a {ActionName}ResponseTransfer

UKHD8KTMF

and then if I need to actually return something I can add stuff

UKHD8KTMF

and I have property isSuccess in it