What are the Slack Archives?
It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.
Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..
Hi there, according to the spryker/router migration guide at
Hi there,
according to the spryker/router migration guide at https://documentation.spryker.com/v4/docs/migration-guide-router we should add a
Spryker\Zed\Router\Communication\Plugin\EventDispatcher\RequestAttributesEventDispatcherPlugin
to our EventDispatcherDependencyProvider
. This Plugin does not exist and it looks like this is causing \Spryker\Zed\Auth\Communication\Plugin\EventDispatcher\AuthorizationEventDispatcherPlugin::onKernelRequest
to fail with endless redirects.
Any chance to provide the plugin source directly until the module is fixed?
Comments
-
u have tryed to install the spryker/auth package? https://github.com/spryker/auth/blob/master/src/Spryker/Zed/Auth/Communication/Plugin/EventDispatcher/AuthorizationEventDispatcherPlugin.php
0 -
if u do not need it, just do not register the plugin
0 -
Hi Julian,
thanks for your response.
Yes, we're using (and depending on) this module.
Like said the\Spryker\Zed\Auth\Communication\Plugin\EventDispatcher\AuthorizationEventDispatcherPlugin::onKernelRequest
is currently failing, because$module = $request->attributes->get('module'); $controller = $request->attributes->get('controller'); $action = $request->attributes->get('action');
always is
null
0 -
Interesting, found an open PR that contains mentioned plugin in
spryker\router
module. Will clarify why it isn't merged. 🤔0 -
Ah ok i thought its missing since u said its missing ^^
0 -
RequestAttributesEventDispatcherPlugin
is the missing one. 🙂
@valerii.trots thanks!0 -
oh sorry, did overread it twice -.-
0 -
@valerii.trots sorry for pushing, but is there any chance to provide me with the unmerged plugin so I can test it? This currently blocks me updating our project and I'm afraid this won't be the last issue 🙂
0 -
Seems to be a mistake to mention it in the migration guide. Currently, the \Spryker\Zed\Application\Communication\Plugin\ServiceProvider\RequestServiceProvider takes care of this and this is added on core level which will be fixed in the Silex removal PR.
0 -
Not sure if I got you right.
\Spryker\Zed\Application\Communication\Plugin\ServiceProvider\RequestServiceProvider
is deprecated. How will it be replaced if not by the missing new Plugin?0 -
It will be replaced later, currently there is no need to change anything about it as it is delivered and used in core.
0 -
But it will only be used if you call
\Spryker\Zed\Application\ApplicationDependencyProvider::getServiceProviders
which will also trigger a deprecated warning:protected function getServiceProviders(Container $container) { trigger_error( '\Spryker\Zed\Application\ApplicationDependencyProvider::getServiceProviders is deprecated, please copy all required ServiceProvider and remove the call to this method', E_USER_DEPRECATED ); [...]
0 -
But your suggestion is to not use the missing plugin but keep the deprecated
RequestServiceProvider
until it's replaced, right?0 -
Seems so. At least I understood it in this way.
0 -
I can confirm that using the
RequestServiceProvider
also solved the mentioned issue.0
Categories
- All Categories
- 42 Getting Started & Guidelines
- 7 Getting Started in the Community
- 8 Additional Resources
- 7 Community Ideas and Feedback
- 75 Spryker News
- 924 Developer Corner
- 783 Spryker Development
- 88 Spryker Dev Environment
- 362 Spryker Releases
- 3 Oryx frontend framework
- 35 Propel ORM
- 68 Community Projects
- 3 Community Ideation Board
- 30 Hackathon
- 3 PHP Bridge
- 6 Gacela Project
- 25 Job Opportunities
- 3.2K 📜 Slack Archives
- 116 Academy
- 5 Business Users
- 370 Docker
- 551 Slack General
- 2K Help
- 75 Knowledge Sharing
- 6 Random Stuff
- 4 Code Testing
- 32 Product & Business Questions
- 70 Spryker Safari Questions
- 50 Random