Hi, I'm trying to update an order ```$order = new OrderTransfer(); $order->setEmail('

U01G4K5E0J2

Hi,
I'm trying to update an order

$order = new OrderTransfer();
$order->setEmail('<mailto:steve.rogers@example.org|steve.rogers@example.org>');
/** @var SalesFacadeInterface $salesFacade **/
$salesFacade->updateOrder($order, $orderId);

and I get

Call to a member function getTaxTotal() on null

because during this update OrderUpdater wants to create order totals

    protected function createOrderTotals(OrderTransfer $orderTransfer, SpySalesOrder $orderEntity)
    {
        $taxTotal = 0;
        if ($orderTransfer->getTotals()->getTaxTotal()) {
            $taxTotal = $orderTransfer->getTotals()->getTaxTotal()->getAmount();
        }
...

am I doing something wrong or missing something?

UKJND3A3H

That updateOrder() method is not prepared to only process adjusted properties imo. So it runs though the update stack that contains lots of different aspects, like the one you encountered.

It might be easier (necessary) to create your own custom facade method to cover the particular use case

UKJND3A3H

The error itself happens as getTotals() on OrderTransfer returns null instead of another TransferObject, as you did not populate it. You couuuuuuld try to create an empty one (TotalsTransfer? not sure) and try once more. But I feel even if it would work at the moment, the risk of this breaking at some point is… too big

giovanni.piemontese

Why u want update an order entity in this form? Can u please explain what is your goal?

U01G4K5E0J2

I dont see why not

U01G4K5E0J2

scrambling email and deleting all other user related data, just as CustomerFacade::anonymizeCustomer does

U01G4K5E0J2

but I've already figured out how to do that

UKJND3A3H

There’s always some project with some expectations. I think that updateOrder is just not aimed to cover such cases

UKJND3A3H

you could create your own scrambleUserData($orderId) that internally is passing by the existing OrderFacade’s capabilities

UKJND3A3H

Ah ok, so already figured out a way. Which way did you chose? 🙂

giovanni.piemontese

I thing that the clean way is this to manage via oms. When u want to do it?

U01G4K5E0J2

pulled orders from a query and updated entities, like a caveman 😉

giovanni.piemontese

Oh no please. Why not update the customer data fields with a command by order in oms state machine?

U01G4K5E0J2

sue me

U01G4K5E0J2

😉

giovanni.piemontese

There u have the whole order entity and u have just to run your business logic and stop.