Good Morning everyone, i have a strange error from Architecture check that run as git pre-commit ho

giovanni.piemontese

Good Morning everyone,

i have a strange error from Architecture check that run as git pre-commit hook.. Here the error:

[Command "Architecture check" (file: ./src/Pyz/Zed/Cart/CartDependencyProvider.php) fails] PHP Fatal error:  Uncaught TypeError: Argument 2 passed to ArchitectureSniffer\Common\Bridge\BridgeMethodsRule::findNotMatchingMethodsForBridgeInterface() must be an instance of ReflectionClass, null given, called in /Users/gpiemontese/Projects/projekt.local/project/vendor/spryker/architecture-sniffer/src/Common/Bridge/BridgeMethodsRule.php on line 98 and defined in /Users/gpiemontese/Projects/projekt.local/project/vendor/spryker/architecture-sniffer/src/Common/Bridge/BridgeMethodsRule.php:177
Stack trace:
#0 /Users/gpiemontese/Projects/projekt.local/project/vendor/spryker/architecture-sniffer/src/Common/Bridge/BridgeMethodsRule.php(98): ArchitectureSniffer\Common\Bridge\BridgeMethodsRule->findNotMatchingMethodsForBridgeInterface(Object(PHPMD\Node\InterfaceNode), NULL)
#1 /Users/gpiemontese/Projects/projekt.local/project/vendor/spryker/architecture-sniffer/src/Common/Bridge/BridgeMethodsRule.php(61): ArchitectureSniffer\Common\Bridge\BridgeMethodsRule->verifyInterface in /Users/gpiemontese/Projects/projekt.local/project/vendor/spryker/architecture-sniffer/src/Common/Bridge/BridgeMethodsRule.php on line 177

I don't understand where is the problem... Has anyone any idea how to fix it?

Thank u all in advance!

Chemaclass

can you share your ./src/Pyz/Zed/Cart/CartDependencyProvider.php ?

giovanni.piemontese

Gerne 🙂

Chemaclass

Do you have an interface for that Bridge? CartToQuoteFacadeBridge 🤔

The failing is because BridgeMethodsRule::getBridgedInterfaceReflection() is returning a null , and that’s being used in BridgeMethodsRule:98 when calling the findNotMatchingMethodsForBridgeInterface that expects a ReflectionClass and it doesn’t allows null. That’s why you get that TypeError.

giovanni.piemontese

yes... i have an interface...
Do u think is that the problem?

Chemaclass

The question is: “why is getBridgedInterfaceReflection returning null?”

giovanni.piemontese

yes, clear... i know.. but why it happend?

giovanni.piemontese

yes, right.. why returning null!?

Chemaclass

Can you share the CartToQuoteFacadeBridge ? and maybe also the interface?

giovanni.piemontese

here ...

Chemaclass

I know it will sound stupid, but try adding the constructor to your child class (I know, it’s not necessary from code perspective, but maybe the sniffer is not that clever after all…)

/**
 * @param \Spryker\Zed\Quote\Business\QuoteFacadeInterface $quoteFacade
 */
public function __construct($quoteFacade)
{
    $this->quoteFacade = $quoteFacade;
}

giovanni.piemontese

ok, but then i have also to call the parent construct or not?

Chemaclass

becase, according with that method to avoid getting null you need:
1. a constructor
2. a PHPDoc on the constructor
3. one argument on the constructor
4. that argument must be the interface of the class that you are bridging

giovanni.piemontese

ok, i will try.. thanks

giovanni.piemontese

i give u a feedback if it works

Chemaclass

yes, yes, that’s correct, using the parent constructor would better 🙂

/**
 * @param \Spryker\Zed\Quote\Business\QuoteFacadeInterface $quoteFacade
 */
public function __construct($quoteFacade)
{
    parent::__construct($quoteFacade);
}

giovanni.piemontese

YES... U are right!!! it works!

Thank u very much..

Chemaclass

Something new that we just learned today 🙂

giovanni.piemontese

Absolut...

"you never stop learning" !