Hi, I am currently manipulating the prices in our shop with a company-based margin. So far - so good

ULL0N440J

Hi, I am currently manipulating the prices in our shop with a company-based margin. So far - so good. But now I am stuck at one last point: the PriceProductMapper seems to has no link to the customer at all.

I was wondering, if I could prepare accessing the current customer (->getCompanyUserTransfer()->getCompanyBusinessUnit()->getMargin()) in the DependencyProvider. I've added the following function in the DependencyProvider order to access the customer of QuoteTransfer:

protected function addQuoteClient(Container $container)
    {
        $container[static::CLIENT_QUOTE] = function (Container $container) {
            return new PriceProductToQuoteClientBridge($container->getLocator()->quote()->client());
        };

        return $container;
    }

calling quote() there brings up the message Method 'quote' not found in \Generated\Zed\Ide\AutoCompletion|\Spryker\Shared\Kernel\LocatorLocatorInterface. Any ideas, how to get this running? 😨

ULL0N440J

More Meta: when returning the MoneyValueTransfer, i am adding an individual multiplier in /src/Pyz/Zed/PriceProduct/Business/Model/Product/PriceProductMapper.php.
This file doesn't know the Customer (yet). See my thoughts on how to solve this above)

Andriy Netseplyayev

in which method are you using calling the addQuoteClient method? Is is provideBusinessLayerDependencies()?

Andriy Netseplyayev

another point: if possible, try to get rid of bridges in project scope, e.g. instead of return new PriceProductToQuoteClientBridge() just return return $container->getLocator()->quote()->client()

Andriy Netseplyayev

it’s a general Spryker recommendation

ULL0N440J

in which method are you using calling the addQuoteClientmethod? Is is provideBusinessLayerDependencies()?

Yes. /src/Pyz/Zed/PriceProduct/PriceProductDependencyProvider.php:provideBusinessLayerDependencies()

Andriy Netseplyayev

Now, to the point: you might be doing something wrong, if you intent to provide Client in Zed …

Andriy Netseplyayev

First of all, you might end-up in “Zed is calling Zed” situation, which for sure you don’t want to do.

Andriy Netseplyayev

On the other side, Client might try to query Session, which is not right to do from Zed

Andriy Netseplyayev

Can you investigate, what’s your target method in the client, what should it call eventually?

Andriy Netseplyayev

if you feel like providing PriceProductMapper with information about customer - I would go for extending the incoming transfer object with customerId and passing it from Yves. But it is still doesn’t feel right, there might be some “hook” point where you would introduce your plugin or so. I just don’t know your exact business use case

ULL0N440J

My scenario is: I want to receive the current customer. I thought it was refrenced and accessible in the provided QuoteTransfer 🤔 I had a look at another function CompanyUserInvitationPageDependencyProvider:addCustomerclient() where the CustomerClient was called from given container,.

In an Yves module I am accessing the current customer with CustomerClient return $customer->getCompanyUserTransfer()->getCompanyBusinessUnit()->getMargeRate();

I get you, doesn't appear to be correct to open a Client to request data from Zed 🤦‍♂️

Now, to the point: you might be doing something wrong, if you intent to provide Client in Zed …

Andriy Netseplyayev

@ULL0N440J can this be interesting to you?
https://documentation.spryker.com/capabilities/price/prices_per_merchant_relations/price-per-merchant-relation.htm

Andriy Netseplyayev

If it’s not exactly what you’re looking for, maybe you could have a look how it is implemented and find the good solution?

Andriy Netseplyayev

I get you, doesn’t appear to be correct to open a Client to request data from Zed 🤦‍♂️

Zed is customer-session agnostic, period. You can pass customer ID from Yves to Zed, and then Zed can fetch customer information, if needed.

Andriy Netseplyayev

I thought it was refrenced and accessible in the provided QuoteTransfer

that should be it, quote must have a customerId (if it’s not a guest)

ULL0N440J

We've already had a look at product lists. We couldn't use this, because we would have to import our products as lists many times (each time, when someone wants to add a new margin. This could reach from 0.1% to x%.. think this would not be viable)

Andriy Netseplyayev

@ULL0N440J product lists won’t work here. What about the link I’ve sent above - prices per Merchant relation?

Andriy Netseplyayev

I would not go towards persisting the all (prices * customers) combinations. Rather store customer margin for customer, and then add % on the fly, when you calculate the quote, by introducing a new item for your calculation stack. That worked for us just perfectly fine.

Andriy Netseplyayev

just don’t forget to store the current margin value together with the sales order, to make sure you can “explain” the price in the future

Andriy Netseplyayev

but really, have a look at “prices per Merchant relation” feature

ULL0N440J

prices per Merchant relation

I get you. We've had a look on this way already, too. Quite difficult to explain our whole Idea for the Shop:

We would have to set the merchant relations in Yves. Our (kind-of)Admins won't be able to access Zed.
This is where I failed last time; I wasn't able to create merchant-relations from yves 😣

Andriy Netseplyayev

ahhh, you’re building market place. So you want the Yves to be also a place where vendors define prices for the customers..

Andriy Netseplyayev

hmmm, yeah, it very depends on your specific and the way how you’re building things already.. Why is it not possible to create a new “relation” by doing Yves->Zed call?

ULL0N440J

Why is it not possible to create a new “relation” by doing Yves->Zed call?

Didn't find out, how to solve this properly. There was no Client I could use. All I found (but didn't help to get further) was a MerchantRelationToCSV... 🤔

Andriy Netseplyayev

Well, then you need to introduce one, definitely

Andriy Netseplyayev

along with gateway controller(action) and maybe a dedicated facade method. That would sound to me as a right solution

ULL0N440J

I will definitly get back to this later. We've committed to solve it quick and dirty for now. I've translated every call to setNetAmount() by given multiplier. As long as a customer is provided this works fine for us.

ULL0N440J

Going back to the initial question - How can I access the customer(client) from the container? The container appears to have a quoteTransfer linked to it. This contains a customerTransfer / customerID

Andriy Netseplyayev

Now I lost you..
now you want customer client instead of quote ? And I don’t understand how container (dependency container?) appears to have a quoteTransfer linked to it.. How is this connected with the original question?

ULL0N440J

Sorry.
All QuoteClients I've seen so far (QuoteTransfer) are containing a customer.
I added the function

protected function addQuoteClient($container): Container
    {
        $container[static::CLIENT_QUOTE] = function (Container $container) {
            return new PriceProductToQuoteClientBridge($container->getLocator()->quote()->client());
        };

        return $container;
    }

to src/Pyz/Zed/PriceProduct/PriceProductDependencyProvider.php. I thought I could access the customer in this QuoteTransfer (and resolve it by customerClient.. or request it directly, I am in Zed already). By this, I could receive the Company with its own margin