What are the Slack Archives?

It’s a history of our time together in the Slack Community! There’s a ton of knowledge in here, so feel free to search through the archives for a possible answer to your question.

Because this space is not active, you won’t be able to create a new post or comment here. If you have a question or want to start a discussion about something, head over to our categories and pick one to post in! You can always refer back to a post from Slack Archives if needed; just copy the link to use it as a reference..

is it possible to override package.json from a module inside vendor (let's say spryker-gui's package

UKKQKJ9FX
UKKQKJ9FX Posts: 38 🧑🏻‍🚀 - Cadet
in Help

is it possible to override package.json from a module inside vendor (let's say spryker-gui's package.json) The repo name for package pace changed and it is neccessairy in spryker/gui.
You can see that https://git@github.com/hubspot/pace.git#c6846cbf6b928e9903b569269fa9fbf32f2554f4 redirects you.
I was wondering if packagej.json was extendable and how?

Comments

  • UKKQKJ9FX
    UKKQKJ9FX Posts: 38 🧑🏻‍🚀 - Cadet

    maybe using oryx for zed ?

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    edited November 2020

    Hi Filip, seems that we got a support request about the same problem.

    Because of https://github.com/CodeByZach/pace/issues/505 there is https://github.com/CodeByZach/pace/issues/508. So it seems that we need to fix it ASAP on our side.

    Sorry that I can't answer to your initial question.

  • UKKQKJ9FX
    UKKQKJ9FX Posts: 38 🧑🏻‍🚀 - Cadet

    Thanks !

  • UKKQKJ9FX
    UKKQKJ9FX Posts: 38 🧑🏻‍🚀 - Cadet

    Will the fix work with earlier Sprykers releases. we are depending on Sprykers 3.0 Gui and are not in the position to update. @valerii.trots

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice

    Do you mean that it would be good to backport the fix as 3.0.1?

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice

    As latest spryker/gui is still 3.x - 3.37.0.

  • UKKQKJ9FX
    UKKQKJ9FX Posts: 38 🧑🏻‍🚀 - Cadet
    edited November 2020

    My bad, the version is 3.19.0, and it would be apriceated if the fix would persist to these earliers versions

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice

    I'm not sure if Spryker is doing backports for minors but we will see. I'll leave a note that backport is needed.

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice
    edited November 2020

    As I expected, sorry:

    Valerii Trots [2:18 PM]
Are we creating backports for minors in general?

Valerii Trots  [2:18 PM]
There is a request in the community to create a backport of fix for spryker/gui:3.19.0 as they are on this version at the moment and there is a blocking issue that there is a PR already for.

xxx [2:20 PM]
you mean inside a major and inside a minor?
no, thats also technically problematic.
they must go to the highest minor/patch of that major release. and there it should be fixed.
  • UKMHZV8LX
    UKMHZV8LX Posts: 69 🧑🏻‍🚀 - Cadet

    Can you tell, when you expect the fix to be published? Currently our Zed frontend building process fails, keeping us from doing deployments.

  • UKMHZV8LX
    UKMHZV8LX Posts: 69 🧑🏻‍🚀 - Cadet

    And yes: We are not on the latest major as well

  • Valerii Trots
    Valerii Trots SRE @ Spryker Sprykee Posts: 1,654 ✨ - Novice

    Our release manager decided to postpone releasing prepared fix until there is a feedback from the owner of the package if he is bringing v to tags names or not.

  • UKMHZV8LX
    UKMHZV8LX Posts: 69 🧑🏻‍🚀 - Cadet
    edited November 2020

    Yes, understand

  • UKMHZV8LX
    UKMHZV8LX Posts: 69 🧑🏻‍🚀 - Cadet

    If there are people who cannot wait:

    /**
 * @return string
 */
public function getZedInstallerDirectoryPattern()
{
    return [
        $this->get(KernelConstants::SPRYKER_ROOT) . '/[!gui]*/assets/Zed',
        APPLICATION_ROOT_DIR . '/src/Pyz/Zed/Gui/assets',
    ];
}
  • UKMHZV8LX
    UKMHZV8LX Posts: 69 🧑🏻‍🚀 - Cadet

    A patch for SetupFrontendConfig

  • UKMHZV8LX
    UKMHZV8LX Posts: 69 🧑🏻‍🚀 - Cadet

    And place the package.json file under /src/Pyz/Zed/Gui/assets

  • UKMHZV8LX
    UKMHZV8LX Posts: 69 🧑🏻‍🚀 - Cadet

    v is back 🙂

Categories