Hi, I got the following error: *Spryker\Shared\ZedRequest\Client\Exception\TransferNotFoundExceptio

ULL0N440J

Hi, I got the following error:

Spryker\Shared\ZedRequest\Client\Exception\TransferNotFoundException - No class name given for Transfer generation.

I actually know what this error is about (returning a proper transfer). In my usecase I am returning an array of MerchantRelationshipTransfer. Do I need to create a
MerchantRelationshipCollectionTransfer() (CollectionTransfer doesn't exist yet) or is it possible to solve it "easier"?

UM53ZHLTF

Probably just remove the *Transfer suffix from your property. The declaration should be without just the ClassName

ULL0N440J

Not sure if I got you right. This here is my current code

/**
 * @param  \Generated\Shared\Transfer\CompanyBusinessUnitTransfer $companyBusinessUnit
 * @return \Generated\Shared\Transfer\MerchantRelationshipTransfer[]
 */
public function getMerchantRelationshipCollectionByOwnerCompanyBusinessUnitAction(CompanyBusinessUnitTransfer $companyBusinessUnit) {
    $facade = new MerchantRelationshipFacade();
    $allMR = $facade->getMerchantRelationshipCollection();
    $currentMR = [];

    foreach($allMR as $merchantRelation) {
        if($merchantRelation->getOwnerCompanyBusinessUnit()->getIdCompanyBusinessUnit() == $companyBusinessUnit->getIdCompanyBusinessUnit()) {
            $currentMR[] = $merchantRelation;
        }
    }

    return $currentMR;
}

UM53ZHLTF

Ok you can return an array of Transfers. Thats not a problem. It looks more like you dont have the MerchantRelationshipTransfer in first place. Does it exist?

UM53ZHLTF

Side note, don't instantiate business objects in your code, pass them as dependencies. So the MerchantRelationshipFacadeshould be a dependency

ULL0N440J

It looks more like you dont have the MerchantRelationshipTransfer in first place. Does it exist? (edited)

the $allMR contains several Objects of type MerchantRelationshipTransfer

UM53ZHLTF

Ah let me guess, you trying it from a gatewayController right?

UM53ZHLTF

so for a client/Stub call. Then you need a proper wrapper transfer yes.

ULL0N440J

Ah, alright 😅 there we go, sorry if I wasn't clear enough at the beginning.

ULL0N440J

Side note, don't instantiate business objects in your code, pass them as dependencies. So the MerchantRelationshipFacadeshould be a dependency

Thanks for the hint, this was just a first try. I'll move this code anyway. Currently this is nested in the GatewayController from product-list. I'll move this specific function to merchant-relation. There I can access the facade directly.

UM53ZHLTF

no worries, the easiest is to just wrap this in *ResponseTransfer where you also set the status

UM53ZHLTF

ok 👍

Andriy Netseplyayev

Side note, don’t instantiate business objects in your code, pass them as dependencies. So the MerchantRelationshipFacadeshould be a dependency

so in case of a GatewayController it must not be a dependency, it should be resolved by $this->getFacade() to the right (current module’s) facade 😉

ULL0N440J

Moved everything nice and clean into merchant-relation bundle today.
Getting back to this topic: how do I wrap an entity into a responseTransfer?
My first thought on this would be to define a new transferObject like project/src/Pyz/Shared/MerchantRelation/Transfer/merchant_relationship_collection.transfer.xml 😅