Hey.. is there a plan to make shipments-rest-api compatible with the ne shipments group? It seems th

UPDQFGGM9

Hey.. is there a plan to make shipments-rest-api compatible with the ne shipments group? It seems that my shipment is always set to null because the ShipmentGroupTransfer is empty.

We use a price plugin so every time findShipmentGroupShippingPrice in MethodPriceReader is called the call will fail due to the missing GroupTransfer.

Or it is not passed through here: https://github.com/spryker/spryker-core/blob/master/Bundles/Shipment/src/Spryker/Zed/Shipment/Business/ShipmentMethod/MethodReader.php#L100

Valerii Trots

Hi Chris, our development took a look at your problem and they found an issue in the code regarding price plugin. They will create an internal ticket for fixing but it can take a while due to priorities.

So to unblock you there are two possible workarounds.

1. At first, a price plugin must implement the old deprecated interface \Spryker\Zed\Shipment\Communication\Plugin\ShipmentMethodPricePluginInterface

In the \Spryker\Zed\Shipment\Business\ShipmentMethod\MethodPriceReader::findShipmentGroupShippingPrice() method line 81 add this code:

$pricePlugin = $this->getPricePlugin($shipmentMethodTransfer);
return $pricePlugin->getPrice($quoteTransfer);

2. In the \Spryker\Zed\Shipment\Business\ShipmentMethod\MethodReader::findAvailableMethodById() method lines 99-100 replace the code with this one:

        $shipmentGroupTransfer = (new ShipmentGroupTransfer())
            ->setShipment((new ShipmentTransfer())
                ->setMethod($shipmentMethodTransfer)
                ->setShippingAddress($quoteTransfer->getShippingAddress()))
            ->setItems($quoteTransfer->getItems());
        $storeCurrencyPrice = $this->methodPriceReader
            ->findShipmentGroupShippingPrice($shipmentMethodTransfer, $quoteTransfer, $shipmentGroupTransfer);

This will work for both old and new price plugins.

But in general Glue doesn't support split shipment yet so it can be that this won't help. AFAIK split shipment in Glue is on the roadmap but without any ETA.

UKBF1R1S5

@valerii.trots i found a solution for that. I created a PR: https://github.com/spryker/spryker/pull/7239

Valerii Trots

Thanks, will communicate this internally.