spryker/product-image-storage 1.15.0 causing exceptions
Hello,
4 days ago this commit was introduced with a new tag 1.15.0
in spryker/product-image-storage
.
https://github.com/spryker/product-image-storage/commit/ab4e157b84b07a2006d17cfbc3b0145e230b6e62#diff-126f52f35440e9105c3[…]35f7fc5a4e68702d9e719b81
The bridge now has an array as fixed type, however, the underlying storage-client has multiple return types null|array|....
This causes exceptions whenever the underlying storage-client return something else than array.
I did not know where else to contact than here, as the issue board on github is deactivated. ❤
Comments
-
fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,056 ⚖️ - Guardians (admin)
Hey, good catch! I reported it internally. If you want to push priority you can do this by creating a bug issue through either the partner portal (if you work for an official partner agency) or the customer portal (if you work for a customer right now). There is normally a business person on project level who has access to it.
If there was a ticket submitted please let me know so i can let it be linked to the one i reported 🙂
0 -
There is no urgency as 1.14.0 is also available and working well so far.
We just pinned that version.
Ty for reaction ❤
0 -
Hey everyone, we just updated
spryker/product-image-storage
to version 1.15.0 and with this change https://github.com/spryker/product-image-storage/compare/1.14.0...1.15.0#diff-69f3fb1747c034c9e847e1bc861258e9dcdd9581a0a12e76ab8f943fa744a488R17 it broke our implementation due to this errorERROR - Declaration of Spryker\Client\Storage\StorageClientInterface::get($key) must be compatible with Spryker\Client\ProductImageStorage\Dependency\Client\ProductImageStorageToStorageInterface::get($key): array
this happen because we have a Pyz override ofSpryker\Client\Storage\StorageClientInterface
which is extendingProductImageStorageToStorageInterface
for us to be able to have access to\Spryker\Client\Storage\StorageClientInterface::getMulti()
in the places where this bridge is used. Since theget()
method return type is now different in the bridge it gives this error. Just FYI in case this needs to be changed on your side0 -
And I looked a bit deeper and it seems that the underlying StorageClient could potentially return
null
which would then break due to the type not being an array0 -
fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,056 ⚖️ - Guardians (admin)
The more “official” reports through the dedicated support channels the higher prio 🙂 - Here in slack is no official support. Here we help each other - from dev to dev 💪
1 -
Makes sense, thank you for the info 🙏
0 -
fsmeier Senior Software Engineer & Developer Enablement Advocate Sprykee Posts: 1,056 ⚖️ - Guardians (admin)
Heyhey, should be fixed now: https://github.com/spryker/product-image-storage/releases/tag/1.15.1
1
Categories
- All Categories
- 42 Getting Started & Guidelines
- 7 Getting Started in the Community
- 8 Additional Resources
- 7 Community Ideas and Feedback
- 69 Spryker News
- 896 Developer Corner
- 758 Spryker Development
- 83 Spryker Dev Environment
- 361 Spryker Releases
- 3 Oryx frontend framework
- 34 Propel ORM
- 68 Community Projects
- 3 Community Ideation Board
- 30 Hackathon
- 3 PHP Bridge
- 6 Gacela Project
- 23 Job Opportunities
- 3.2K 📜 Slack Archives
- 116 Academy
- 5 Business Users
- 370 Docker
- 551 Slack General
- 2K Help
- 75 Knowledge Sharing
- 6 Random Stuff
- 4 Code Testing
- 32 Product & Business Questions
- 68 Spryker Safari Questions
- 50 Random