Hello All, I've extended the MailToMailerBridge class and added a new method also i have created the

U01NPM6LAG3

Hello All, I've extended the MailToMailerBridge class and added a new method also i have created the interface for the same but getting this below error during travis check on this following command run spryker/architecture-sniffer below is the error screenshot and code. Anyone have any idea on this?

Unknown

Projects should not use bridges. Those are core-only (vendor) specific classes.

UK7KBE2JW

As mentioned in documentation: @(Error)()(Bridges are for core-level only. If you use them at the project-level, you are doing it wrong!)

U01NPM6LAG3

So I can extend it in project level right?

Unknown

No, you can directly use the interfaces and classes
The bridge concept is for decoupling of modules, which is not needed for wiring on project level. See docs.

Ahmed Sabaa

Exactly, as Mark said, you can just use the locator to grab the facade directly and use it’s interface

U010DNAA3QW

By the way, if we just use the interfaces directly on project-level, how are we supposed to handle cases where we depend on type-hints?

A short Example: SalesToStoreInterface is being used as type-hint of method getStoreFacade() in SalesBusinessFactory. When we now pass our own StoreFacadeInterfacade (and not SalesToStoreInterface) in the SalesDependencyProvider, this typehint will be broken. If we override getStoreFacade(): StoreFacadeInterface in our projects SalesBusinessFactory, this will be a php error (because they are not compatible). What's the suggested approach here?

Unknown

Param/Return types are indeed somewhat troublesome in such cases.
If there are not solvable, you can use an adapter like approach (just dont call it Bridge then and the sniffer should also be fine).

giovanni.piemontese

U have to define the construct again in your class on pyz level

    /**
     * @var \Swift_Message
     */
    protected $message;

    /**
     * @var \Swift_Mailer
     */
    protected $mailer;

    /**
     * @param \Swift_Message $message
     * @param \Swift_Mailer $mailer
     */
    public function __construct($message, $mailer)
    {
        parent::__construct($message, $mailer);
    }

and then the architecture sniff would be ok..

giovanni.piemontese

and if u have still the problem, of course smth so can also solve your problem to ignore this rules

/**
 * @SuppressWarnings(PHPMD.BridgeMethodsRule)
 * @SuppressWarnings(PHPMD.BridgeMethodsInterfaceRule)
 */

Ahmed Sabaa

Also, if you have your facade, you should usually implement all the core bridge interfaces there so everything internally in core would work seamlessly