Planned replacement of tslint with eslint
Hello spryker-team,
i have noticed, that spryker will replace tslint with eslint in the next version (CC-25963 Replaced tslint with eslint for YVES. ).
Upon reviewing it for our current development and future updates, i saw the changes in package.json.
I don't think this is an optimal solution, since this only binds the linting to the PYZ-namespace and no custom namespace.
Another suggestion would be to rename the yves:eslint function to just "yves:lint" so any future linter-updates won't break pipelines and functionalities.
Can you share some insight on why you chose to bind this only to PYZ or has this maybe slipped through your internal review?
Comments
-
Hello Sven.
Thank you for good point 🤝
It’s named according to the previous version.
We’ll rename it to the variant without the linter name.0 -
-
My only concern (now) is that is only checking the pyz-namespace and no additional one 😞
before it checked every namespace.
0 -
We expect that the linter must only check project-level YVES components.
According to the folder structure.
Each project can customize the paths according to its requirements.0
Categories
- All Categories
- 42 Getting Started & Guidelines
- 7 Getting Started in the Community
- 8 Additional Resources
- 7 Community Ideas and Feedback
- 68 Spryker News
- 890 Developer Corner
- 753 Spryker Development
- 83 Spryker Dev Environment
- 360 Spryker Releases
- 3 Oryx frontend framework
- 34 Propel ORM
- 68 Community Projects
- 3 Community Ideation Board
- 30 Hackathon
- 3 PHP Bridge
- 6 Gacela Project
- 22 Job Opportunities
- 3.2K 📜 Slack Archives
- 116 Academy
- 5 Business Users
- 370 Docker
- 551 Slack General
- 2K Help
- 75 Knowledge Sharing
- 6 Random Stuff
- 4 Code Testing
- 32 Product & Business Questions
- 68 Spryker Safari Questions
- 50 Random