How do people deal, in general, with inconsistent data in Yves?

UKGT7RC7P

it's not in abstract storage in the DB

UKGT7RC7P

but the abstract product exists

UKGT7RC7P

I'd think event:trigger -rproduct_abstract -i2086 (where 2086 is the abstract product) should solve it?

Andriy Netseplyayev

there could be scenarios when it got disabled and removed from storage, but concretes were not taken care of

UKGT7RC7P

all the concretes seem active

Andriy Netseplyayev

yes it might solve it (if product is valid). But the question is why could that happen

UKGT7RC7P

it doesn't populate the storage table after that

UKGT7RC7P

maybe my pub/sync knowledge is lacking though

UKHD8KTMF

there can be many reasons for this, but my first guess is that you have errors while publishing something

UKHD8KTMF

or if you have super slow queue processing and until messages are processed you have inconsistent state

UKHD8KTMF

I should probably prepare a talk on p&s troubleshooting

UKGT7RC7P

yeah -- would be a good talk 🙂

Ehsan Zanjani

Hi @UKGT7RC7P,
Good to hear from you! 🙂
Yves data consistency for each resource is defined in each storage client as a default logic. if the data is not completed in Redis, you probably get an exception. and project needs to handle this either 404 page or custom logic which defined based on project

Ehsan Zanjani

btw Data consistency can be different or several projects. e.g. Products can be shown even if price is not there, or image is missing

UKGT7RC7P

thanks 🙂 would be good to have some kind of validation in the FE though, as otherwise you would just have to catch all errors and make them 404s

UKGT7RC7P

if you had validation you could verify the data asynchronously

UKGT7RC7P

and deactivate problematic products f.e.

UKGT7RC7P

🤔

Ehsan Zanjani

Let me check this

Ehsan Zanjani

As I said the validation could be different for project implementation, Page can be still rendered with optional missing data, but with mandatory missing data, exception is fine, you don’t need to catch all errors, only those you think it’s mandatory for showing a product which should not be too many.

UKGT7RC7P

yeah, the problem really is that the NULL errors are not handled in Spryker

UKGT7RC7P

so you just get call to method on NULL, undefined index etc

UKGT7RC7P

so I would want to extend the all Spryker things and add some exception handling where anything could be NULL / undefined

Unknown

do you have to handle it before it hits the template?

UKGT7RC7P

there are lots of places where it's assumed that the data is not null

UKGT7RC7P

but it can be

UKGT7RC7P

it can happen in the template, or in the storage client, or anywhere in between

Unknown

do you have a couple of examples at hand?

UKGT7RC7P

vendor/spryker/product-storage/src/Spryker/Client/ProductStorage/Storage/ProductAbstractStorageReader.php:363

UKGT7RC7P

but there are numerous places