How do people deal, in general, with inconsistent data in Yves?

Ehsan Zanjani

@UKGT7RC7P let’s take PDP as an example. if the price is a mandatory filed for showing a PDP, in ProductStorageClient, you can introduce the validation check and throw 404 exception, you don’t need to check all template/pages

UKGT7RC7P

sure -- but overriding the storage client isn't a very nice thing to do

UKGT7RC7P

and there is no built-in way of ensuring consistent data

UKGT7RC7P

whatever your buseiness rules might be

UKGT7RC7P

in the end you just have an unstructured array from storage (or NULL)

Ehsan Zanjani

StorageClient must return transfer-object not array

Ehsan Zanjani

\Spryker\Client\ProductStorage\Finder\AbstractProductViewTransferFinder::findProductViewTransfer()

UKGT7RC7P

my mistake, but that in turn has no validation rules 🙂

Ehsan Zanjani

    /**
     * @param int $idProduct
     * @param string $localeName
     * @param array $selectedAttributes
     *
     * @return \Generated\Shared\Transfer\ProductViewTransfer|null
     */
    public function findProductViewTransfer(int $idProduct, string $localeName, array $selectedAttributes = []): ?ProductViewTransfer

UKGT7RC7P

a product view transfer doesn't mean a valid product view transfer as everything is nullable (which is a general problem with TOs in Spryker - none of them can be guaranteed to be valid at any given point in time but they are used in a way where they are expected to be valid)

UKGT7RC7P

and problems happen in the expanders

Ehsan Zanjani

if expander fails with null or missing index in array, this is a bug and we need to fix it

UKGT7RC7P

(I think I was thinking of the Search / Catalog data when I mentioned the raw arrays)